(#1876, #2086) Create ncids cdns #2055

olitharp-nci · 2025-04-15T20:04:26Z

Removes previous babel and rollup

Closes #1876

Adds workflow permissions since we were messing with the yml anyway

Closes #2086

Pull Request Details

Add description

Closes #

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
The commit message passes all quality commit message standards.
Unit tests have been updated or created to reflect any javascript changes.
Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

WCAG 2.1 Level AA requirements have been met.

Development:

Any new or updated javascript code has 100% unit test coverage.
New or updated breakpoints have regression images.
Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

There are no unexpected or unapproved regression image changes. 
Functionality of interactive elements meet the acceptance criteria.
The product is visually and functionally the same across the different browsers.

Accessibility:

AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
Lighthouse: scores have not noticeably decreased during this PR.
Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing.  

General:

New or updated features introduced in this PR are developed mobile-first.
Breakpoint changes and regression images match those breakpoints.
This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

New code passes code quality standards set by industry standards.
The expected Storybook stories have been added or updated for the new or updated feature.
The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

VoiceOver: Described content matches with what was expected.
Keyboard navigation: new or updated features and content are navigable via the keyboard.

github-actions · 2025-04-15T20:04:42Z

Viewing Information

github-actions · 2025-04-15T20:44:47Z

Viewing Information

.github/workflows/workflow.yml

Copilot

Pull Request Overview

This PR introduces multiple distribution variants for the NCIDS CSS and JavaScript packages, creating three different builds: minimal, standard, and full versions for CDN distribution. The changes replace the previous Babel/Rollup configuration with a new build system that generates multiple outputs for different use cases.

Replaces previous build system with new Rollup configuration for multiple JavaScript builds
Creates three CSS variants (minimal, full, standard) and corresponding JavaScript bundles
Adds CDN packaging and deployment automation through GitHub Actions

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/ncids-js/rollup.config.mjs	New Rollup configuration generating UMD and ESM bundles for three variants
packages/ncids-css/*.scss	New entry points for minimal and full CSS variants
packages/ncids-css/packages/ncids-*/_index.scss	Package definitions for different NCIDS variants
scripts/zip-builds.sh	Script to package CDN distributions
.github/workflows/workflow.yml	GitHub Actions workflow for CDN build and deployment
testing/ncids-css-testing/src/stories/*/.scss	Updated imports to use new variant names

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

.github/workflows/workflow.yml

packages/ncids-js/README.md

.github/workflows/workflow.yml

bryanpizzillo

First round, but it is close to being there.

bryanpizzillo · 2025-08-26T19:22:13Z

packages/ncids-css/packages/ncids-full/_index.scss

+
+// NCIDS
+// -------------------------------------
+@forward 'nci-autocomplete';


Can you pull in minimal into full so we say that we don't have to worry about keeping things in sync.

Also can you forward all the packages we have and don't rely on packages forwarding others. e.g., add nci-back-to-top even though nci-footer imports it. Because today nci-footer imports it, but a pr could go in changing that, and then we would have to know to go here to add it. (and we will most likely forget)

bryanpizzillo · 2025-08-26T20:34:50Z

packages/ncids-js/src/ncids-full.ts

@@ -0,0 +1,13 @@
+/**


These should be auto inits so that someone can just add thse to their page. I think we should exclude anything without a normal autoinit and make a backlog for it.

bryanpizzillo · 2025-08-26T20:35:04Z

packages/ncids-js/src/ncids-minimal.ts

+ * - Footer
+ */
+
+export * from 'src/components/nci-header';


These should be auto inits so that someone can just add thse to their page.

.github/workflows/workflow.yml

bryanpizzillo

The utility classes seem to be missing from the documentation site. I noticed it with the version bar, but all the utility pages are broken.

olitharp-nci · 2025-12-17T16:59:20Z

I can't approve my own PR, but after talking to Bryan last night and looking over all the commits, lgtm (after merging commits)

bennettcc · 2025-12-17T20:37:21Z

Per @blilianyu's testing on 12/17:

The spanish language toggle has a special characters issue

blilianyu

Passes for design cc: @andyvanavery31

Closes #2086

- Added tslib as a dependency for ncids-js as it is a peer dep for rollup typescript. - Updated ncids-css to use vite instead of webpack because it works. There are some plugins for postcss that we could have used, but we know vite works because we use it for storybook. - Setup js example site such that it allows for the use of the built files in ncids-js and ncids-css. Without making super major changes this does require one to make sure they are building those packages before running the test site. In a perfect scenario the ncids-js and ncids-css dependencies would be built before the ncids-js-testing package. - I did update the prepare for ncids-css to also build. This should make sure there is at least some sort of css for ncids-js-testing. ncids-js already builds on prepare. Closes #1876

olitharp-nci force-pushed the ticket/1876-cdn branch from 59a98fa to fd6c268 Compare August 21, 2025 15:18

github-advanced-security bot found potential problems Aug 21, 2025

View reviewed changes

.github/workflows/workflow.yml Fixed Show fixed Hide fixed

olitharp-nci force-pushed the ticket/1876-cdn branch 4 times, most recently from 8ce9801 to 257c8c7 Compare August 26, 2025 15:20

bryanpizzillo requested a review from Copilot August 26, 2025 19:26

Copilot AI reviewed Aug 26, 2025

View reviewed changes

.github/workflows/workflow.yml Outdated Show resolved Hide resolved

packages/ncids-js/README.md Outdated Show resolved Hide resolved

olitharp-nci force-pushed the ticket/1876-cdn branch 2 times, most recently from a9239c4 to c9d1ce5 Compare August 26, 2025 20:08

github-advanced-security bot found potential problems Aug 26, 2025

View reviewed changes

.github/workflows/workflow.yml Fixed Show fixed Hide fixed

bryanpizzillo requested changes Aug 26, 2025

View reviewed changes

olitharp-nci force-pushed the ticket/1876-cdn branch 9 times, most recently from e55bc2a to 1f65e79 Compare September 11, 2025 20:18

github-advanced-security bot found potential problems Sep 11, 2025

View reviewed changes

.github/workflows/workflow.yml Fixed Show fixed Hide fixed

olitharp-nci force-pushed the ticket/1876-cdn branch 6 times, most recently from 5a4bda9 to 646a334 Compare September 16, 2025 13:46

olitharp-nci force-pushed the ticket/1876-cdn branch 5 times, most recently from 3e63950 to a86a921 Compare October 16, 2025 07:55

olitharp-nci force-pushed the ticket/1876-cdn branch from a86a921 to 1a1c385 Compare October 21, 2025 13:44

bennettcc requested a review from a team October 22, 2025 16:10

bryanpizzillo requested changes Nov 3, 2025

View reviewed changes

olitharp-nci force-pushed the ticket/1876-cdn branch 3 times, most recently from ff1ea3e to 70b45ed Compare November 10, 2025 17:45

olitharp-nci force-pushed the ticket/1876-cdn branch 7 times, most recently from 481fb84 to 4c8c38e Compare November 17, 2025 21:35

andyvanavery31 approved these changes Dec 18, 2025

View reviewed changes

blilianyu approved these changes Dec 18, 2025

View reviewed changes

jfrank-nih and others added 2 commits December 18, 2025 13:54

(#2086) Add permissions to workflows

efb09f9

Closes #2086

bryanpizzillo force-pushed the ticket/1876-cdn branch from ddca8ba to dce48d3 Compare December 18, 2025 18:56

bryanpizzillo approved these changes Dec 18, 2025

View reviewed changes

bryanpizzillo merged commit f58b6f4 into develop Dec 18, 2025
6 checks passed

bryanpizzillo deleted the ticket/1876-cdn branch December 18, 2025 20:26

This was referenced Jan 5, 2026

Enabler: Automatically Publish ncids.css to CDN #13

Closed

Enabler: Automatically Publish ncids.js to CDN #15

Closed

(#1876, #2086) Create ncids cdns #2055

(#1876, #2086) Create ncids cdns #2055

Uh oh!

Conversation

olitharp-nci commented Apr 15, 2025 • edited by jfrank-nih Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Details

Author PR Checklist

General:

Accessibility:

Development:

Product Reviewer PR Checklist

General:

Accessibility:

Design Reviewer PR Checklist

General:

Developer Reviewer PR Checklist

General:

Accessibility:

Uh oh!

github-actions bot commented Apr 15, 2025

Viewing Information

Uh oh!

github-actions bot commented Apr 15, 2025

Viewing Information

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bryanpizzillo left a comment

Choose a reason for hiding this comment

Uh oh!

bryanpizzillo Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

bryanpizzillo Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

bryanpizzillo Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bryanpizzillo left a comment

Choose a reason for hiding this comment

Uh oh!

olitharp-nci commented Dec 17, 2025

Uh oh!

bennettcc commented Dec 17, 2025

Uh oh!

blilianyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

olitharp-nci commented Apr 15, 2025 •

edited by jfrank-nih

Loading